mahara-contributors team mailing list archive

[Mahara Bot <1940798@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/12178
Committed: https://git.mahara.org/mahara/mahara/commit/4093a5af00daccb800ec786d4ff9e9db5289bf18
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    21.10_DEV

commit 4093a5af00daccb800ec786d4ff9e9db5289bf18
Author: Doris Tam <doristam@xxxxxxxxxxxxxxx>
Date:   Thu Sep 23 14:18:41 2021 +1200

Bug 1940798: Scroll to 'showcomment' param in URL

If the 'showcomment' parameter exists in the URL,
scroll to where comment with that ID sits on the page.

This includes page comments and artefact comments.
Block comments have not been considered.
Change-Id: Iac3fe5beab59afb11e465fba13797320acff9dc2
(cherry picked from commit e73fef68688624a18bfb3d58a4e0cd730a30e411)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1940798

Title:
  Comment notification doesn't take you to the comment

Status in Mahara:
  Fix Released

Bug description:
  The comment notification email does not take you to the page comment
  itself any more but are left at the top of the page. The comment has
  to be searched for on the page if it is a page comment or the artefact
  found, which can be tricky when there are lots of artefacts on a page.

  The URL is something like view/view.php?id=27&showcomment=180 and
  /view/view.php?id=27&artefact=163&showcomment=181 for a comment on an
  artefact, but you don't jump to the comment.

  To replicate:

  1. PersonA creates a page and includes an image that allows comments.
  2. PersonA shares the page with PersonB and allows comments.
  3. Log in as PersonB and leave a public comment on the page and on the artefact.
  4. Log in as PersonA.
  5. PersonA received a notification with a link to the page comment and a notification with the link to the artefact comment.

  Expected result: Clicking the link in the email that is to take you to
  the comment takes you to the comment. In the case of the artefact
  comment that should open the modal. In case of the page comment, the
  comment should be seen at the top of the page or somehow highlighted
  temporarily.

  Actual result: The link only takes you to the page but not the comment
  or the comment on the artefact.

  There is bug #1940800 that deals with moderated comments.

  This issue doesn't deal with the wishlist item bug #1945248 to
  highlight the comment.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1940798/+subscriptions