mahara-contributors team mailing list archive

[Mahara Bot <1949333@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/12226
Committed: https://git.mahara.org/mahara/mahara/commit/99c84f22f9af19aa79965a292ba1d0d8a9d30be2
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    20.10_DEV

commit 99c84f22f9af19aa79965a292ba1d0d8a9d30be2
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Thu Nov 4 09:46:29 2021 +1300

Bug 1949333: Warning when released from submitted host

Resolved a minor warning in $collection->submittedto().

Change-Id: Ie5ff0cd979dde8d4443ee406e317ddda493d32b3
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1949333

Title:
  Releasing a current submission produces warning

Status in Mahara:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed
Status in Mahara 21.04 series:
  Fix Committed
Status in Mahara 21.10 series:
  Fix Committed
Status in Mahara 22.04 series:
  Fix Committed

Bug description:
  When I submitted a portfolio via LTI to Brightspace and then release
  the submission via the admin interface at Admin menu -> Groups ->
  Current submissions, I get the following warning. There is no warning
  when the portfolio is submitted via a Mahara group.

  [WAR] a3 (lib/mahara.php:1557) sprintf(): Too few arguments
  Call stack (most recent first):

      log_message("sprintf(): Too few arguments", 8, true, true, "/var/www/ws-mahara-testing-mahara/releases/2021102...", 1557) at /var/www/ws-mahara-testing-mahara/releases/20211027023906/lib/errors.php:515
      error(2, "sprintf(): Too few arguments", "/var/www/ws-mahara-testing-mahara/releases/2021102...", 1557, array(size 3)) at Unknown:0
      sprintf("Your portfolio "%s" has been released from "%s" by...", "Internship") at /var/www/ws-mahara-testing-mahara/releases/20211027023906/lib/mahara.php:1557
      format_langstring("Your portfolio "%s" has been released from "%s" by...", array(size 1), "en.utf8") at /var/www/ws-mahara-testing-mahara/releases/20211027023906/lib/mahara.php:558
      get_string_location("portfolioreleasedmessage", "group", array(size 1), "format_langstring", "en.utf8") at /var/www/ws-mahara-testing-mahara/releases/20211027023906/lib/mahara.php:361
      get_string_from_language("en.utf8", "portfolioreleasedmessage", "group", "Internship") at /var/www/ws-mahara-testing-mahara/releases/20211027023906/lib/view.php:1789
      View->release(object(LiveUser), array(size 1)) at /var/www/ws-mahara-testing-mahara/releases/20211027023906/admin/groups/archives.php:93

  
  To replicate:

  
  1. Set up a deep link assignment in Brightspace (Kristina can help with that)
  2. Submit a portfolio as a student.
  3. Log into Mahara as site admin.
  4. Go to Admin menu -> Groups -> Current submissions.
  5. Release the student's portfolio.

  Expected result: The portfolio is released without warning.
  Actual result: The above warning is thrown but the portfolio still seems to be released.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1949333/+subscriptions