mahara-contributors team mailing list archive

[Mahara Bot <1929357@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/12124
Committed: https://git.mahara.org/mahara/mahara/commit/69306ce352c131f79c7bb54ccc9dd504da8cd883
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    main

commit 69306ce352c131f79c7bb54ccc9dd504da8cd883
Author: Dianne Tennent <dianne.tennent@xxxxxxxxxxxxxxx>
Date:   Wed Sep 29 16:56:19 2021 +1300

Bug 1929357: Do not create block when leaving annotation

If people close the annotation edit window or leave
without saving, no block will be created.

Change-Id: Ic37c42bc628fa5fb8f027efa975f321ba6ca6e99

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1929357

Title:
  Adding annotation doesn't alert if you change page without saving -
  leaves empty block on the page

Status in Mahara:
  Fix Committed

Bug description:
  After clicking the dot on the smart evidence page to display the
  annotation modal you decide to reload the page before saving the form
  or exiting out with the 'X' button the empty annotation block still
  exists on the corresponding page.

  When you do this multiple times from the smart evidence page, multiple
  annotations with the same evaluation item are created on the
  corresponding page.

  There needs to be form change checker alert if we are adding the block
  (but not when editing) to alert one when leaving the page. And on
  leaving to clean up the half finished block.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1929357/+subscriptions