mahara-contributors team mailing list archive

[Mahara Bot <1950068@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/12262
Committed: https://git.mahara.org/mahara/mahara/commit/7aca9c7d8113f96d03e245c52afc7607f1b4e0ed
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    20.10_DEV

commit 7aca9c7d8113f96d03e245c52afc7607f1b4e0ed
Author: Evonne <evonne@xxxxxxxxxxxxxxx>
Date:   Tue Nov 9 11:29:22 2021 +1300

Bug 1950068 styles for threaded comments

Changed the calculation to be the border-left width instead as
putting in background but provides the same visual cue.

behatnotneeded

Change-Id: I9ef24c8a7488545f82d008e90695c7858dc9245a
(cherry picked from commit ce8aecd3ec9cbacfe521d9bbb687c3fa0b164189)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1950068

Title:
  Styles missing in new collapsed comments section

Status in Mahara:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed
Status in Mahara 21.04 series:
  Fix Committed
Status in Mahara 21.10 series:
  Fix Committed
Status in Mahara 22.04 series:
  Fix Committed

Bug description:
  This issue was introduced in Mahara 21.10. When you have threaded
  comments turned on, you can't distinguish the indentation for replies
  easily any more as there is no colour difference.

  See the attached image vs. the screenshot at
  https://manual.mahara.org/en/21.04/portfolio/feedback.html#view-page-
  comments : In 21.04 the background distinguished indented comments,
  whereas now there is no background to do so.

  To replicate:

  1. Allow 'Threaded comments' in the institution settings.
  2. Create a page (make sure you are a member of the institution) and allow comments on the page.
  3. Add a public comment.
  4. Log in as sb else and reply to the comment.

  Expected result: The comment is indented and visually distinguished from the one you reply to.
  Actual result: The comment is indented, but there is no background change. Everything is still white.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1950068/+subscriptions