mahara-contributors team mailing list archive

[Mahara Bot <1950551@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/12132
Committed: https://git.mahara.org/mahara/mahara/commit/0d6d54d864ba27965b143835b84804c4ad7b5fc5
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    main

commit 0d6d54d864ba27965b143835b84804c4ad7b5fc5
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Fri Oct 8 16:59:46 2021 +1300

Bug 1950551: changing the non-carousel gallery to just use a modal popup

Change-Id: Id67fc5579e87e8a9634cc1c2cd0e69dc96407802
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1950551

Title:
  Gallery thumbnail popup has alternate slideshow but shouldn't have
  this

Status in Mahara:
  Fix Committed

Bug description:
  We have a bootstrap slideshow so we don't need another one in the
  gallery thumbnails as part of the image popup.

  We should instead use the bootstrap modal for the popups in the
  gallery thumbnails.

  To test, before patch:

  Add a gallery with square-thumbs chosen.

  Display the page and click on an image in the gallery

  The popup has a play button in it.

  After the patch:

  The popup is just a modal popup now

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1950551/+subscriptions