mahara-contributors team mailing list archive

[Kristina Hoeppner <1953095@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

When a page is submitted to the LMS, e.g. Moodle, via LTI (1.1), the
'submitted host' info is not displayed in the notification. It looks
like this:

---
From: System

To: NAME

This is to confirm that you submitted the page "Page title" successfully
to the external host "" at 01 December 2021, 11:02pm.

If you have any questions about this submission, please contact the group administrator. 
---

Whereas for a collection the URL is displayed:

---
From: System

To: NAME

This is to confirm that you submitted the collection "Collection title"
successfully to the external host "https://LMS-DOMAIN"; at 01 December
2021, 10:54pm.

If you have any questions about this submission, please contact the group administrator.
---

The collection has the 'submittedhost' line in the code:
https://git.mahara.org/mahara/mahara/-/blob/main/htdocs/lib/collection.php#L1808
whereas the view does not:
https://git.mahara.org/mahara/mahara/-/blob/main/htdocs/lib/view.php#L1759

It will need to be added.

While making this change, it would be good to update the language string
'messageexternal' and replace 'If you have any questions about this
submission, please contact the group administrator.' with 'If you have
any questions about this submission, please contact your course
administrator.'


To replicate:

1. Set up LTI 1.1 in an institution.
2. Set up 2 LTI activities in Moodle.
3. As student, submit a page to one activity and a collection to another.
4. Check the notifications. In both cases, the external host URL should be mentioned in the notification.

** Affects: mahara
     Importance: Medium
         Status: Confirmed

** Affects: mahara/21.10
     Importance: Medium
         Status: Confirmed

** Affects: mahara/22.04
     Importance: Medium
         Status: Confirmed


** Tags: bite-sized

** Also affects: mahara/22.04
   Importance: Medium
       Status: Confirmed

** Also affects: mahara/21.10
   Importance: Undecided
       Status: New

** Changed in: mahara/21.10
       Status: New => Confirmed

** Changed in: mahara/21.10
   Importance: Undecided => Medium

** Changed in: mahara/21.10
    Milestone: None => 21.10.1

** Changed in: mahara/22.04
    Milestone: None => 22.04.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1953095

Title:
  'Submitted host' info not displayed for pages submitted via LTI

Status in Mahara:
  Confirmed
Status in Mahara 21.10 series:
  Confirmed
Status in Mahara 22.04 series:
  Confirmed

Bug description:
  When a page is submitted to the LMS, e.g. Moodle, via LTI (1.1), the
  'submitted host' info is not displayed in the notification. It looks
  like this:

  ---
  From: System

  To: NAME

  This is to confirm that you submitted the page "Page title"
  successfully to the external host "" at 01 December 2021, 11:02pm.

  If you have any questions about this submission, please contact the group administrator. 
  ---

  Whereas for a collection the URL is displayed:

  ---
  From: System

  To: NAME

  This is to confirm that you submitted the collection "Collection
  title" successfully to the external host "https://LMS-DOMAIN"; at 01
  December 2021, 10:54pm.

  If you have any questions about this submission, please contact the group administrator.
  ---

  The collection has the 'submittedhost' line in the code:
  https://git.mahara.org/mahara/mahara/-/blob/main/htdocs/lib/collection.php#L1808
  whereas the view does not:
  https://git.mahara.org/mahara/mahara/-/blob/main/htdocs/lib/view.php#L1759

  It will need to be added.

  While making this change, it would be good to update the language
  string 'messageexternal' and replace 'If you have any questions about
  this submission, please contact the group administrator.' with 'If you
  have any questions about this submission, please contact your course
  administrator.'


  To replicate:

  1. Set up LTI 1.1 in an institution.
  2. Set up 2 LTI activities in Moodle.
  3. As student, submit a page to one activity and a collection to another.
  4. Check the notifications. In both cases, the external host URL should be mentioned in the notification.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1953095/+subscriptions