mahara-contributors team mailing list archive

[Mahara Bot <1950199@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/12356
Committed: https://git.mahara.org/mahara/mahara/commit/30676ef27b800ea0b0ffcc4e1a4edc78030760a6
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    21.10_DEV

commit 30676ef27b800ea0b0ffcc4e1a4edc78030760a6
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Tue Nov 9 10:46:25 2021 +1300

Bug 1950199: Reset mahara timezone after saml cron breaks it

There is a part of the SAML core code that sets the timezone to UTC
when creating the metadata refresh file.

This causes all cron jobs after it in the same run to use the
incorrect timezone

Change-Id: Id6c741b439ef42c50edc844878969f90e24a29b6
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit 5a239852fb2c166c19f46d42acf59035aeabb40b)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1950199

Title:
  SimpleSamlphp metadata refresh causing cron problems

Status in Mahara:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed
Status in Mahara 21.04 series:
  Fix Committed
Status in Mahara 21.10 series:
  Fix Committed
Status in Mahara 22.04 series:
  Fix Committed

Bug description:
  When we have:
  1) a site has a timezone / country selected
  2) a site that has SAML installed
  3) an institution set up with a SAML auth instance
  4) the SAML auth instance has 'Metadata URL for auto-refresh' set to a valid value

  The timezone gets changed because of the getTime() method in the
  htdocs/auth/saml/extlib/simplesamlphp/modules/metarefresh/lib/MetaLoader.php
  file setting the timezone to UTC.

  This means any cron job happening after the
  PluginAuthSaml::auth_saml_refresh_cron one will be using the wrong
  'time' to compare to and so some cron jobs won't run when they should.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1950199/+subscriptions