mahara-contributors team mailing list archive

[Mahara Bot <1949914@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/12229
Committed: https://git.mahara.org/mahara/mahara/commit/912275460d194cf3f134cbe1c9a4dd223b3cad24
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    main

commit 912275460d194cf3f134cbe1c9a4dd223b3cad24
Author: Dianne Tennent <dianne.tennent@xxxxxxxxxxxxxxx>
Date:   Fri Nov 5 15:40:07 2021 +1300

Bug 1949914: adjust mark-up in json editor

Adjustments to mark-up from jsoneditor
library to be accessible and semantically
correct.

Change-Id: Ia8ca50b6e32760f6b543a371b2ac7e8a17f7a571

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1949914

Title:
  SmartEvidence editor accessibility bug fixes for button alignment and
  heading levels

Status in Mahara:
  Fix Committed

Bug description:
  Related to this bug: https://bugs.launchpad.net/mahara/+bug/1824056
  And this patch: https://reviews.mahara.org/#/c/12215/2

  Things I noticed while improving accessibility on this SmartEvidence
  editor (json-editor):

  1. Alignment between the 'collapse' and 'add' buttons in the
  'Standards' and 'Standard elements' headings is slightly off. See
  attached screenshot.

  2. All of the headings in the editor are h3 tags that wrap around a
  few divs and buttons. This is semantically incorrect and I suspect is
  what is preventing the screen reader from reading the h3 heading text.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1949914/+subscriptions