← Back to team overview

mahara-contributors team mailing list archive

[Bug 1959733] A change has been merged

 

Reviewed:  https://reviews.mahara.org/12406
Committed: https://git.mahara.org/mahara/mahara/commit/24cdeca063776ad03fad68d0e9dc94835b55a140
Submitter: Gold (gold@xxxxxxxxxxxxxxx)
Branch:    20.10_DEV

commit 24cdeca063776ad03fad68d0e9dc94835b55a140
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Fri Feb 4 12:21:24 2022 +1300

Bug 1959733: Allowing old pages with broken layout update to gridstack

This is where the column value for a block is greater than the number
of columns for that row

Change-Id: Id1c321ca13abbb771767f7a3494db2612845ff9f
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1959733

Title:
  Needing to respect the default layout mode of a page

Status in Mahara:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed
Status in Mahara 21.04 series:
  In Progress
Status in Mahara 21.10 series:
  Fix Committed
Status in Mahara 22.04 series:
  Fix Committed

Bug description:
  When we make a page in a desktop browser (gridstack desktop mode) and
  then edit the page on a mobile browser (gridstack mobile mode) it
  mucks up the layout of the page and makes all the blocks have width =
  1.

  We need to do the following:
  1 Page created in desktop but changes made in mobile: Keep desktop width dimensions.
  2. New page created in mobile: Set the default width to the default desktop width instead of
  using width=1 column.
  3. In Mobile: When to block configuration is updated by clicking the 'Save' button, don't change the block dimension, but leave it on what is there. Only change the block dimension when the block
  is actively resized on mobile, but not when block content is save

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1959733/+subscriptions



References