← Back to team overview

mahara-contributors team mailing list archive

[Bug 1954869] A change has been merged

 

Reviewed:  https://reviews.mahara.org/12310
Committed: https://git.mahara.org/mahara/mahara/commit/807965adbf8c8e6fa59e8bcf137f3ab461daf688
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    main

commit 807965adbf8c8e6fa59e8bcf137f3ab461daf688
Author: Dianne Tennent <dianne.tennent@xxxxxxxxxxxxxxx>
Date:   Mon Dec 20 10:42:01 2021 +1300

Bug 1954869: PHPStan errors in ADOdb

New patch to replace previous patch with a
smaller set of fixes that don't stop the page
loading.

This reverts commit 7c0027e7291de0bd648590abca9d1b2a9b0d20dc.

Change-Id: Ic0948016ac46fcd3f83914e051cf782f84c9a9a1

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1954869

Title:
  PHPStan errors in htdocs/lib/adodb - level 0

Status in Mahara:
  Fix Committed

Bug description:
  Fix errors uncovered by PHPStan in ADOdb library (Error log output
  attached to this bug)

  Once all the fixes are made, a pull request should be made to ADOdb.

  Reviews of that pull request should also be applied to this patch
  before merging with Mahara main.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1954869/+subscriptions



References