mahara-contributors team mailing list archive

[Mahara Bot <1958509@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/12420
Committed: https://git.mahara.org/mahara/mahara/commit/6d4b6b6453e6d5277c4114d931cb98648f3da9a8
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    21.10_DEV

commit 6d4b6b6453e6d5277c4114d931cb98648f3da9a8
Author: Doris Tam <doristam@xxxxxxxxxxxxxxx>
Date:   Tue Jan 25 17:17:00 2022 +1300

Bug 1958509: Rewrite text block instruction + text references

Artefacts mentioned in the artefact_file_embedded are tied to
block instances. When we copy a page, the embedded artefacts
get copied, therefore we need to add new references to the db
table.

Change-Id: I2b8ef30d8edc106513a74c11b115563fff0fdd3a
(cherry picked from commit e64b3c0a27062d0d60f4de8b78fe2972b48fa6d6)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1958509

Title:
  Update the block id of embeddedurls when pages are copied

Status in Mahara:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed
Status in Mahara 21.04 series:
  Fix Committed
Status in Mahara 21.10 series:
  Fix Committed
Status in Mahara 22.04 series:
  Fix Committed

Bug description:
  During the copying of a page, when a block that can hold embeddedurls
  (e.g. text blocks) is copied, the $configdata['text'] of that block is
  not updated to point to the duplicated block that is in the new page.

  Fixing this will make sure that only the owner of the file can download the file.
  Currently, the issue of not updating the block id means that when embeddedurl-supporting blocktype such as text block is copied, anyone can download it

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1958509/+subscriptions