mahara-contributors team mailing list archive

[Mahara Bot <1960997@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/12429
Committed: https://git.mahara.org/mahara/mahara/commit/90079194a7b6fc9924eb3a7fc90ad94592831afb
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    main

commit 90079194a7b6fc9924eb3a7fc90ad94592831afb
Author: Doris Tam <doristam@xxxxxxxxxxxxxxx>
Date:   Wed Feb 16 17:21:34 2022 +1300

Bug 1960997: Check $USER is admin for some institution settings

When checking $values['maxuseraccounts'] and $values['maxgroups']
add check that they're admin so that institution admins don't get
an error thrown as that setting is not available to them.

Change-Id: Ie8b0a3751e55faebe648e1f0f833985f43cac0ac

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1960997

Title:
  Errors thrown when institution admin edits institution settings

Status in Mahara:
  Fix Committed

Bug description:
  When institution admins edit institution settings, they get thrown
  errors saying index undefined for setting options only available to
  admins.

  Errors are thrown for fields maxuseraccounts and maxgroups introduced
  in Bug #1947643

  Fix: Add the same check that allows those options to be displayed to
  where they're checked

  Steps:
  1. Create an institution
  2. Add a member as an institution admin (who is not a site admin)
  3. Log in as the institution admin
  4. Go to that institution's settings page
  5. Edit a setting and press 'Submit'

  Expected: No errors
  Actual:  Undefined index: maxuseraccounts and maxgroups

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1960997/+subscriptions