mahara-contributors team mailing list archive

[Dianne Tennent <1959613@xxxxxxxxxxxxxxxxxx>]

After further investigation, the 'Access denied' error above no longer
appears for some reason.

So we have a case where annotations have been enabled for the site, but
the institution settings have not been changed to 'Allow peers to see
portfolio content'.

In this case, when someone shares their smart evidence portfolio with a
peer, their peer cannot see their portfolio content, but they can add
feedback to annotations.

At the moment, even for a page, someone can choose to share their
portfolio with a peer, even if their institution hasn't allowed peers to
see portfolio content.

Perhaps we need to review 'Allow peers to see portfolio content'
settings, to remove the option for sharing with peers and remove ability
to add feedback as a peer, if this setting hasn't been enabled.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1959613

Title:
  Problem with annotation feedback and draft feedback

Status in Mahara:
  In Progress

Bug description:
  Problem:

  Person A creates a Smart evidence collection and has an annotation block on a page
  Person B adds a draft comment to it
  Person A requests the comment to be made public
  Person B gets an email and follows the link

  -- gets error
  [WAR] e2 (artefact/lib.php:353) Artefact type mismatch. You are trying to use this annotation as a comment.
  Call stack (most recent first):

      ArtefactType->__construct() at /../htdocs/artefact/comment/lib.php:193
      ArtefactTypeComment->__construct() at /../htdocs/view/view.php:563

  To test:
   
  1 Set up new site
  2 Go to Plugin Extensions page and activate annotation
  3 Edit 'No institution' and turn on Annotations
  4 Upload some users to the site (via CSV is easiest)
  5 Log in as Person A and create a page
  6 Create a collection with a smart evidence option chosen and add page to it
  7 Share the collection to Person B with special role Peer
  8 Go to the collection's smart evidence page and add annotation to one of the dots
  9 Log in as Person B and go to the collection smart evidence page and click on the circle dot
  10 Leave some feedback and turn 'Mark public' to No - the feedback should have "This feedback is private."
  11 Log in as Person A and go to the page itself in the collection and click on Feedback (1) link in annotation block
  12 In the modal click the 'Make public' button - you should see "A message has been sent to Person B to request that the feedback be made public."
  13 Log in as Person B and go to the page itself in the collection - you see "You cannot see the content on this page because it does not require a peer assessment."
  14 Go to your inbox and see "Request to change private feedback to public"
  15 Click the 'Annotation' link in the email and get the error.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1959613/+subscriptions