mahara-contributors team mailing list archive

[Mahara Bot <1960979@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/12438
Committed: https://git.mahara.org/mahara/mahara/commit/604d29ab8095db16fee2063885e719446416351d
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    21.04_DEV

commit 604d29ab8095db16fee2063885e719446416351d
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Wed Feb 16 14:28:03 2022 +1300

Bug 1960979: Allowlist the dataroot language section for help files

Change-Id: I44711db9e4aaa5b5e57eefc0840a49d2c3ba57a6
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit be09347dd3ee272abc3e26bdb61d7dea2397390c)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1960979

Title:
  Language pack help files not showing - default to English version

Status in Mahara:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed
Status in Mahara 21.04 series:
  Fix Committed
Status in Mahara 21.10 series:
  Fix Committed
Status in Mahara 22.04 series:
  Fix Committed

Bug description:
  Since language packs are usually installed in the dataroot directory,
  the is_valid_help_page()  function always results in loading the
  English help texts as a fallback.

  To see this in action go to the artefact/file/index.php page, select
  another language, eg German, and click on the help icon by the title.

  The help text popup has the English version in it

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1960979/+subscriptions