← Back to team overview

mahara-contributors team mailing list archive

[Bug 1962464] Re: Always show search bar when editing a note

 

Dear Kristina

The easiest way would be to change
theme/raw/template/form/artefactchooser.tpl to:

<div id="artefactchooser-body">
    <div class="artefactchooser-splitter">
        <div id="artefactchooser-searchform" class="artefactchooser-search input-group clearfix {if !$searchable} d-none{/if}">
            <label class="sr-only" for="artefactchooser-searchfield">
                {str tag=search section=mahara}
            </label>
            <input type="text" class="text form-control" id="artefactchooser-searchfield" name="search" value="{$.request.search}" tabindex="42">
            <input type="hidden" name="s" value="1">
            <span class="input-group-append">
                <button class="submit btn btn-secondary" type="submit" id="artefactchooser-searchsubmit" name="action_acsearch_id_{$blockinstance}" tabindex="42">
                    {str tag=search}
                </button>
            </span>
        </div>

        <div id="{$datatable}" class="artefactchooser-data list-group list-group-lite list-group-top-border">
            {if !$artefacts}
            <span class="noartefacts lead">
                {str tag=noartefactstochoosefrom section=view}
            </span>
            {else}
            {$artefacts|safe}
            {/if}
        </div>

        {$pagination|safe}
    </div>
</div>

I don't know the Mahara code and its internals well enough to know the
implications of this change. It shows the search bar always if the
artifactschooser is searchable. I don't know the places where the
artefactchooser is used outside of note editing and what affect this
will have on other places. For my use-case this would works. Tested on
my local installation of mahara.

Cheers
Pascal

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1962464

Title:
  Always show search bar when editing a note

Status in Mahara:
  Confirmed

Bug description:
  Problem: If you use notes moderatly or extensively then it is very
  seldom, that the note you want to use is on the first, second or third
  page. You then normally use the search. To open it it needs another
  click.

  Solution: Always display the search field (then you can as well remove
  the unnecessary taba "Browse"/"Search"). No functionally gets lost but
  regular users win by a lot.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1962464/+subscriptions



References