mahara-contributors team mailing list archive

[Doris Tam <1964295@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

The creation of progress pages, from Bug 1922634: Portfolio review
block, which made these pages official views type='progress' did not
borrow the view config of existing pages.

When the new progress page was saved to a collection, the existing
pages' config updated according to the progress page which did not have
any config set to anything, e.g. 'allowcomments' not set which defaulted
the rest of the pages in the collection to have 'allowcomments' set to
'No'.

Fix: Once the progress page is added it means the old index = 0 is now
index = 1, so we add a flag to make sure the second page's config (with
existing config) are propagated.

Test:

1. Have a fresh 20.10 site.
2. Be a member of an institution with 'Portfolio completion' set to 'Yes'.
3. Create a collection with portfolio completion and one other page.
4. Check that the page setting 'Allow comments' is set to 'Yes' and save.
5. Upgrade the site to main.
6. Go to the access settings of a page in your collection.
7. Expand the 'Advanced options' and check that 'Allow comments' is still set to 'Yes'.

Expected: The setting for 'Allow comments' is the same before and after the upgrade step.
Actual: The setting for 'Allow comments' is set to 'No'.

** Affects: mahara
     Importance: Critical
     Assignee: Doris Tam (doristam)
         Status: New

** Affects: mahara/21.04
     Importance: Undecided
         Status: New

** Affects: mahara/21.10
     Importance: Undecided
         Status: New

** Affects: mahara/22.04
     Importance: Critical
     Assignee: Doris Tam (doristam)
         Status: New

** Changed in: mahara
    Milestone: 22.10.0 => 21.04.4

** Changed in: mahara
    Milestone: 21.04.4 => 21.10.2

** Changed in: mahara
    Milestone: 21.10.2 => 21.04.4

** Changed in: mahara
     Assignee: (unassigned) => Doris Tam (doristam)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1964295

Title:
  Upgrade step: add "progress" page overwrites the access config in the
  collection

Status in Mahara:
  New
Status in Mahara 21.04 series:
  New
Status in Mahara 21.10 series:
  New
Status in Mahara 22.04 series:
  New

Bug description:
  The creation of progress pages, from Bug 1922634: Portfolio review
  block, which made these pages official views type='progress' did not
  borrow the view config of existing pages.

  When the new progress page was saved to a collection, the existing
  pages' config updated according to the progress page which did not
  have any config set to anything, e.g. 'allowcomments' not set which
  defaulted the rest of the pages in the collection to have
  'allowcomments' set to 'No'.

  Fix: Once the progress page is added it means the old index = 0 is now
  index = 1, so we add a flag to make sure the second page's config
  (with existing config) are propagated.

  Test:

  1. Have a fresh 20.10 site.
  2. Be a member of an institution with 'Portfolio completion' set to 'Yes'.
  3. Create a collection with portfolio completion and one other page.
  4. Check that the page setting 'Allow comments' is set to 'Yes' and save.
  5. Upgrade the site to main.
  6. Go to the access settings of a page in your collection.
  7. Expand the 'Advanced options' and check that 'Allow comments' is still set to 'Yes'.

  Expected: The setting for 'Allow comments' is the same before and after the upgrade step.
  Actual: The setting for 'Allow comments' is set to 'No'.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1964295/+subscriptions