mahara-contributors team mailing list archive

[Mahara Bot <1964268@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/12487
Committed: https://git.mahara.org/mahara/mahara/commit/896d29cefafd2cd906ad51b74850d6707eeee19f
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    20.10_DEV

commit 896d29cefafd2cd906ad51b74850d6707eeee19f
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Wed Mar 9 12:34:14 2022 +1300

Bug 1964268: Copied signoff blocks to self need db row

When copying a signoff block from another owners page it sets up a row
in view_signoff_verify as expected. But when copying own page it
doesn't

So fixed that and have upgrade step to fix existing data

Change-Id: Id372a5da29aaaf53884ffee60ae8b9d9b4738992
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1964268

Title:
  Sign-off and verificatio nstatus not saved to database on copied
  portfolio

Status in Mahara:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed
Status in Mahara 21.04 series:
  Confirmed
Status in Mahara 21.10 series:
  Fix Committed
Status in Mahara 22.04 series:
  Fix Committed

Bug description:
  When you copy a portfolio with the sign-off and verification block,
  the status is not saved to the database unless it's a direct copy of a
  template portfolio.

  To replicate:

  1. Allow portfolio completion for the institution.
  2. Create a page and add the 'sign-off' block.
  3. Add the page to a collection with the portfolio completion active.
  4. On the page or the portfolio completion page, click the 'Sign-off' icon.
  5. Refresh the page.

  Results:
  - Expected: The green tick stays.
  - Actual: The green tick is visible.

  6. Copy the portfolio.
  7. Click the 'Sign-off' icon.
  8. Refresh the page.

  Results:
  - Expected: The green tick stays.
  - Actual: The green tick is not visible but the red dot is because the row is not actually saved into the database.

  Additional scenarios to test:

  1. The verification icon should also be clickable.
  2. When a template (on the site) is copied, the icons need to be clickable and their status saved.
  3. When a copy of the copied template is made, the status needs to be saved.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1964268/+subscriptions