mahara-contributors team mailing list archive

[Mahara Bot <1964835@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/12499
Committed: https://git.mahara.org/mahara/mahara/commit/37ec5c6a9498def9abdcc58df79e29844391410b
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    main

commit 37ec5c6a9498def9abdcc58df79e29844391410b
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Tue Mar 15 11:29:29 2022 +1300

Bug 1964835: Returning the correct institution theme

Change-Id: Ibd3655ef226e7030375e00be8ba209e908c59772
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1964835

Title:
  Configurable theme not set properly for institution members

Status in Mahara:
  Fix Committed

Bug description:
  The configurable theme is not properly selected any more for
  institution members on the main branch that will be Mahara 22.04.
  Everything still works fine in 21.10, but institution members don't
  see the configurable theme any more when the site is upgraded are
  installed anew.

  To replicate:

  1. Install a 21.10 site and set up an institution with the configurable theme. The default values are fine.
  2. Add a member to that institution (don't use the site admin but create a new account to rule out anything else).
  3. Log in as the newly created account holder. You will see the purple header for the configurable theme and not the 'Raw' theme.
  4. Upgrade the site to the 'main' branch and perform the upgrade.
  5. Log in as the newly created account holder.

  Results:
  - Expected: It still shows the purple header indicating the configurable theme is selected.
  - Actual: It's the 'Raw' theme that is used instead.

  The same is true when you have a fresh database on the main branch:

  1. On the main branch with a fresh DB, set up an institution with the configurable theme. The default values are fine.
  2. Add a member to that institution (don't use the site admin but create a new account to rule out anything else).
  3. Log in as the newly created account holder. 

  Results:
  - Expected: It still shows the purple header indicating the configurable theme is selected.
  - Actual: It's the 'Raw' theme that is used instead.

  You can further test that by setting '$cfg->sitethemeprefs = true;' in
  config.php and going to Account menu -> Settings -> Preferences. The
  site theme is selected whereas it should have been the configurable
  theme.

  When fixing the issue, please also create a Behat test for the simple
  scenario on the main branch, not the upgrade scenario.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1964835/+subscriptions