mahara-contributors team mailing list archive

[Mahara Bot <1959860@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/12509
Committed: https://git.mahara.org/mahara/mahara/commit/85f411c166667f88a14ec67af7a6a1c665f106a0
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    21.10_DEV

commit 85f411c166667f88a14ec67af7a6a1c665f106a0
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Mon Mar 7 14:57:01 2022 +1300

Bug 1959860: Plugin info link needs to work as button also

Before we were checking only for a <A> parent but now
we check for either an <A> or <Button> parent that has the data
attribute we need.

This patch makes it possible to click the 'Info' button at
Admin menu -> Extensions -> Plugin administration -> courseinfo
and have the modal appear with the additional information.

Change-Id: I3a94c21d84933662f67f7e35a2a1887e845693d9
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit 47f03585252a9e7ffcd6b0882c3469df2da8c68c)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1959860

Title:
  Courseinfo blocktype plugin modal is blank

Status in Mahara:
  Fix Committed
Status in Mahara 21.10 series:
  Fix Committed
Status in Mahara 22.04 series:
  Fix Committed

Bug description:
  On main branch.

  Go to Admin/Extensions/Plugin Administration
  Click the 'Info' icon next to the 'Courseinfo' blocktype plugin setting

  Expected:
  Modal appears with information

  Actual:
  Blank modal appears

  This seems to be a regression of this patch here:
  https://bugs.launchpad.net/mahara/+bug/1903618

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1959860/+subscriptions