mahara-contributors team mailing list archive

[Mahara Bot <1950069@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/12505
Committed: https://git.mahara.org/mahara/mahara/commit/0322f5a7771307a949b3162cf90319eb05fe405d
Submitter: Doris Tam (doristam@xxxxxxxxxxxxxxx)
Branch:    21.04_DEV

commit 0322f5a7771307a949b3162cf90319eb05fe405d
Author: Evonne <evonne@xxxxxxxxxxxxxxx>
Date:   Thu Nov 11 10:53:33 2021 +1300

Bug 1950069 Removing ratings stars underline

Also fontawesome wasn't displaying the solid star due to incorrect
weight and file reference.

steps: 1. turn on comments rating in institution
2. make a page
3. add comment form choose a 3 star rating, save

Expected: comment should display 3 solid stars and 2 outline stars
Actual: comment displays 5 outline stars

behatnotneeded

Change-Id: I9619605b9eca03bcd8cffcdb6389a059a12cb8e8
(cherry picked from commit 782b87d8f49ab8d9555d5ca757deef986c1c94a4)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1950069

Title:
  Comment ratings have a link underline when they shouldn't

Status in Mahara:
  Fix Committed
Status in Mahara 21.04 series:
  In Progress
Status in Mahara 21.10 series:
  In Progress
Status in Mahara 22.04 series:
  Fix Committed

Bug description:
  Comment ratings have a link underline when you don't hover over them
  when they shouldn't as it makes them harder to distinguish (see
  attachment).

  To replicate:

  1. Allow comment ratings in Admin menu -> Extensions -> Plugin administration -> comment.
  2. Add a comment to a page with a comment rating.
  3. Refresh the page to see the comment.

  Expected result: There are no underlines between the symbols when not hovering over them.
  Actual result: There are link underlines between the symbols when not hovering over them.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1950069/+subscriptions