mahara-contributors team mailing list archive

[Mahara Bot <1966367@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/c/mahara/+/12525
Committed: https://git.mahara.org/mahara/mahara/commit/00659a95055839d797968bcb3c946f1014b2bfeb
Submitter: "Robert Lyon <robertl@xxxxxxxxxxxxxxx>"
Branch:    main

commit 00659a95055839d797968bcb3c946f1014b2bfeb
Author: Doris Tam <doristam@xxxxxxxxxxxxxxx>
Date:   Tue Mar 29 18:19:45 2022 +1300

Bug 1966367: Add strtolower for username, email, and remoteuser checks
in webservices

Change-Id: Ie6c9ca818939c69761b1b0d2e71217f2584e9ba4

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1966367

Title:
  The webservice mahara_view_external.php looks to check for a user
  wrong

Status in Mahara:
  Fix Committed
Status in Mahara 20.10 series:
  Confirmed
Status in Mahara 21.04 series:
  Confirmed
Status in Mahara 21.10 series:
  Confirmed
Status in Mahara 22.04 series:
  Fix Committed

Bug description:
  We store username and email in Mahara in lowercase and therefore
  compare passed in username or email against the database as lowercase
  versions.

  However in webservices it looks like we don't do that and just compare
  what is passed in so if we have $value['username'] = 'ExamplePerson'
  it won't match on the person in the database with 'exampleperson' but
  it should as usernames are lowercase unique in the database.

  Need to update the checkuser() functions in
  webservice/functions/mahara_institution_external.php
  webservice/functions/mahara_user_external.php
  webservice/functions/mahara_view_external.php
  webservice/functions/mahara_blog_external.php

  So that those functions check the username and email in a lowercase
  fashion

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1966367/+subscriptions