← Back to team overview

mahara-contributors team mailing list archive

[Bug 1966363] A change has been merged

 

Reviewed:  https://reviews.mahara.org/c/mahara/+/12516
Committed: https://git.mahara.org/mahara/mahara/commit/d7904aa4a72b44fccc021228aea7b671e69f452a
Submitter: "Robert Lyon <robertl@xxxxxxxxxxxxxxx>"
Branch:    main

commit d7904aa4a72b44fccc021228aea7b671e69f452a
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Fri Mar 25 12:09:29 2022 +1300

Bug 1966363 - Allow for affiliated emails be added on 2nd login

When we do the update steps rather then create steps
- Adds any email that doesn't already exist
- Makes sure the primary email stays the same before as long as
the primary email is one of the current affiliated ones otherwise
defaults back to what is in 'email' field

Change-Id: I120e39224533cdae19f7114ee16a6c39d2bae527
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1966363

Title:
  The SAML change for affiliated emails not working correctly

Status in Mahara:
  Fix Committed

Bug description:
  When a new person is created via saml login and they have affiliated
  emails coming thru then all the emails are added to the person along
  with the one in the 'email' option and the one that is made primary
  will be the one that comes from the affiliation where their permission
  is highest.

  But when they log in again their affiliated emails are ignored.

  This would be fine if all people only ever logged in after the change.

  But if there are existing people in the site then they never get their
  affiliated emails

  We need to do some logic for updating existing people on SAML login

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1966363/+subscriptions



References