← Back to team overview

mahara-contributors team mailing list archive

[Bug 1929357] A change has been merged

 

Reviewed:  https://reviews.mahara.org/c/mahara/+/12585
Committed: https://git.mahara.org/mahara/mahara/commit/707bba07b1ca1290e6d1ba0ad53549d853333a26
Submitter: "Robert Lyon <robertl@xxxxxxxxxxxxxxx>"
Branch:    main

commit 707bba07b1ca1290e6d1ba0ad53549d853333a26
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Thu Apr 7 14:43:13 2022 +1200

Bug 1929357 - adding back in the hide dock

So that when others are giving feedback the dock closes

Change-Id: I71c9f36784ad6b42cf0fd2bcf6fc3e1c212953e3
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1929357

Title:
  Adding annotation doesn't alert if you change page without saving -
  leaves empty block on the page

Status in Mahara:
  Fix Committed

Bug description:
  After clicking the dot on the smart evidence page to display the
  annotation modal you decide to reload the page before saving the form
  or exiting out with the 'X' button the empty annotation block still
  exists on the corresponding page.

  When you do this multiple times from the smart evidence page, multiple
  annotations with the same evaluation item are created on the
  corresponding page.

  There needs to be form change checker alert if we are adding the block
  (but not when editing) to alert one when leaving the page. And on
  leaving to clean up the half finished block.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1929357/+subscriptions



References