mahara-contributors team mailing list archive

[Mahara Bot <1967811@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/c/mahara/+/12565
Committed: https://git.mahara.org/mahara/mahara/commit/d51a822fb27e3b2d751ae8a02cd5c5ddff703cb2
Submitter: "Robert Lyon <robertl@xxxxxxxxxxxxxxx>"
Branch:    21.04_DEV

commit d51a822fb27e3b2d751ae8a02cd5c5ddff703cb2
Author: Gold <gold@xxxxxxxxxxxxxxx>
Date:   Tue Apr 12 13:23:46 2022 +1200

Bug 1967811: Set submittableto = 1 in a MySQL friendly manner.

This SQL is also compatible with how MySQL does things.

Change-Id: I9630fb137eae0791ffac2d5e9e3ea04e3bed29ef
Signed-off-by: Gold <gold@xxxxxxxxxxxxxxx>
(cherry picked from commit 2505ba8b8cf5c3d606c1263570d5e947ade19875)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1967811

Title:
  SQL vs MySQL on group table update

Status in Mahara:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Committed
Status in Mahara 21.04 series:
  In Progress
Status in Mahara 21.10 series:
  In Progress
Status in Mahara 22.04 series:
  Fix Committed

Bug description:
  I was switching DBs for ES7 testing on a smaller dataset. The smaller db is on MySQL.  During the site upgrade I got this:
  ```
  [DBG] 66 (lib/dml.php:180) mysqli error: [1093: You can't specify target table 'group' for update in FROM clause] in EXECUTE("
              UPDATE "group" SET submittableto = 1 WHERE id IN (
                  SELECT g1.id FROM "lti_assessment" l
                  JOIN "group" g1 ON g1.id = l.group
                  WHERE g1.submittableto = 0
              )")Command was:
              UPDATE "group" SET submittableto = 1 WHERE id IN (
                  SELECT g1.id FROM "lti_assessment" l
                  JOIN "group" g1 ON g1.id = l.group
                  WHERE g1.submittableto = 0
              )
  ```

  This is related to this review:
  https://reviews.mahara.org/c/mahara/+/12492

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1967811/+subscriptions