← Back to team overview

mahara-contributors team mailing list archive

[Bug 1969257] A change has been merged

 

Reviewed:  https://reviews.mahara.org/c/mahara/+/12640
Committed: https://git.mahara.org/mahara/mahara/commit/c053adbf05730e56a67e1cfe7a11521f27e3ea81
Submitter: "Robert Lyon <robertl@xxxxxxxxxxxxxxx>"
Branch:    22.04_DEV

commit c053adbf05730e56a67e1cfe7a11521f27e3ea81
Author: Dianne Tennent <dianne.tennent@xxxxxxxxxxxxxxx>
Date:   Wed Apr 20 12:21:29 2022 +1200

Bug 1969257: General page instructions stay visible

Even when there are custom page instructions added in
the advanced settings, allow the general page instructions
to still be visible when in 'Edit' mode.

Change-Id: I5cc982309af76fd0210a145188a778560fc321e6
(cherry picked from commit 2bcbad95b1ebcf8e342eed32f9eaee4ae42fac07)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1969257

Title:
  General page instructions lost when there are specific instructions
  are set

Status in Mahara:
  Fix Committed

Bug description:
  This is a regression introduced in bug #1955600: When there are
  specific page instructions set, the general text "This is a preview of
  your page. Changes are saved automatically..." is removed. This
  shouldn't happen because this text, especially also the accessible
  text is important to keep.

  To replicate:

  1. Create a new page.
  2. View it in 'Edit mode'. The general information on editing a page are displayed, starting with 'This is a preview...".
  3. Add instructions via 'Settings' -> 'Advanced'.

  Results:
  - Expected: The general information text is still displayed when switching to 'Edit' mode.
  - Actual: The general information text is removed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1969257/+subscriptions



References