mahara-contributors team mailing list archive

[Mahara Bot <1975712@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/c/mahara/+/12826
Committed: https://git.mahara.org/mahara/mahara/commit/2229997e7e3f0e4eeed7c83a9ce2ce0f1f5b3050
Submitter: "Robert Lyon <robertl@xxxxxxxxxxxxxxx>"
Branch:    main

commit 2229997e7e3f0e4eeed7c83a9ce2ce0f1f5b3050
Author: Christina Thee Roperto <christinatheeroperto@xxxxxxxxxxxxxxx>
Date:   Thu May 26 15:20:42 2022 +1000

bug 1975712: fix image rotation on external file system

removing the flag $generateifpossible
when checking if resizedimagefile is readable

Change-Id: I84fa7451539d158f3de9a68b26079601126c89c2

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1975712

Title:
  image rotation fails if there is an external file system

Status in Mahara:
  Fix Committed

Bug description:
  Rotating image breaks when using objectfs plugin as an external file
  system.

  Steps to reproduce (with 21.10):

  1. Fresh install mahara
  2. Install https://github.com/catalyst/mahara-module_aws and https://github.com/catalyst/mahara-module_objectfs
  3. Configure the plugin with test s3 crendentials
  4. Add this in config.php

  $cfg->externalfilesystem = array(
     "includefilepath" => "module/objectfs/classes/s3_file_system.php",
     "class" => "module_objectfs\\s3_file_system"
  );

  5. Upload an image on the artefact (site/artefact/file/index.php) 
  6. Rotate the image. It would be broken and the only way to fix is to move back orientation to 0

  
  This is related to: https://bugs.launchpad.net/mahara/+bug/1776364

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1975712/+subscriptions