mahara-contributors team mailing list archive

[Mahara Bot <1976414@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/c/mahara/+/12831
Committed: https://git.mahara.org/mahara/mahara/commit/3139ec6b439ce7125a930d086ad8bdf0be03d762
Submitter: "Robert Lyon <robertl@xxxxxxxxxxxxxxx>"
Branch:    main

commit 3139ec6b439ce7125a930d086ad8bdf0be03d762
Author: Gold <gold@xxxxxxxxxxxxxxx>
Date:   Wed Jun 1 10:53:25 2022 +1200

Bug 1976414: PHP8 Compatibility: admin

Removed a var from a couple of fetch_etag() calls. It was a global var.

Added a default value for smarty $headingclass

Change-Id: I24840ee69d52f9906d19c771d834e73c21c9ef17

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1976414

Title:
  PHP 8 Compatibility: admin

Status in Mahara:
  Fix Committed

Bug description:
  This is to track patchsets that will bring the codebase up to be
  compliant with PHP 8.1.

  The initial run through will be on a top level directory basis. i.e.
  the directories below htdocs. It will focus on the results from the
  PHPStan and Phan static analysis tools.

  This bug tracks files in the admin directory

  Testing will require identifying, from the patchset, where the code is
  used and then verifying that that area of the site still works in both
  PHP 7.4 and PHP 8.1.

  https://phpstan.org/
  https://github.com/phan/phan

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1976414/+subscriptions