mahara-contributors team mailing list archive

[Mahara Bot <1976408@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/c/mahara/+/12820
Committed: https://git.mahara.org/mahara/mahara/commit/f0609e0727b76e4a21468dfe79877f65fc441cd1
Submitter: "Robert Lyon <robertl@xxxxxxxxxxxxxxx>"
Branch:    main

commit f0609e0727b76e4a21468dfe79877f65fc441cd1
Author: Gold <gold@xxxxxxxxxxxxxxx>
Date:   Wed May 25 10:19:00 2022 +1200

Bug 1976408: Resolving SQL errors on PHP8.1 during site install

While standing up on an empty DB the PHP8.1 version showed a decent
number of SQL errors while the PHP7.4 version did not. These errors are
due to code talking to the DB before the site is installed and the
absence of the tables throwing the errors.

Note the PHP 7.4 and 8.1 sites are served from the same codebase with
the same config and DB.

I've adjusted the get_config('installed') check to also make sure the
config table exists in the database as well.

Signed-off-by: Gold <gold@xxxxxxxxxxxxxxx>
Change-Id: I68efbf9744761fefcf6212b4786190165d271c99

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1976408

Title:
  PHP 8 Compatibility: root dir / misc

Status in Mahara:
  Fix Committed

Bug description:
  This is to track patchsets that will bring the codebase up to be
  compliant with PHP 8.1.

  The initial run through will be on a top level directory basis.  i.e.
  the directories below htdocs. It will focus on the results from the
  PHPStan and Phan static analysis tools.

  This bug tracks files in the htdocs directory and other miscellaneous
  patchsets that don't fit neatly into updates for a specific directory.

  Testing will require identifying, from the patchset, where the code is
  used and then verifying that that area of the site still works in both
  PHP 7.4 and PHP 8.1.

  https://phpstan.org/
  https://github.com/phan/phan

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1976408/+subscriptions