mahara-contributors team mailing list archive

[Mahara Bot <1918357@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/c/mahara/+/12108
Committed: https://git.mahara.org/mahara/mahara/commit/8590747cda81e5ba97a1ac80d847b86518500575
Submitter: "Robert Lyon <robertl@xxxxxxxxxxxxxxx>"
Branch:    main

commit 8590747cda81e5ba97a1ac80d847b86518500575
Author: Doris Tam <doristam@xxxxxxxxxxxxxxx>
Date:   Tue Jun 1 12:32:43 2021 +1200

Bug 1915975: Upgrade bootstrap4 to bootstrap5

Adding compatibility to the new sass:
-> converting node-sass to dart-sass

- remove old bootstrap4 repo that wasn't used for anything
- `data-...` classes updated to `data-bs-...`
- updated bootstrap min.js files @ htdocs/lib/bootstrap/assets/javascripts
not sure what they are needed for yet
- the date time picker is not related to bootstrap and is a library of its own
and doesn't have a bootstrap5 version yet
Related to Bug 1918357

Change-Id: Ic0e18a648b6318d90e8d0d2f863de388def237da

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1918357

Title:
  Use dart-sass instead of node-sass for gulp make css

Status in Mahara:
  Fix Committed

Bug description:
  Node-sass uses Lib-sass which is deprecated.

  Node-sass is deprecated and bootstrap recommends dart-sass over it for
  the new version to be compatible with upgrading the library.

  This is related to https://bugs.launchpad.net/mahara/+bug/1918373 with
  reference to https://getbootstrap.com/docs/5.0/getting-started/build-
  tools/#sass for future purposes when we have BS5

  https://getbootstrap.com/docs/5.0/getting-started/build-
  tools/#tooling-setup

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1918357/+subscriptions