mahara-contributors team mailing list archive

[Mahara Bot <1982520@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/c/mahara/+/13021
Committed: https://git.mahara.org/mahara/mahara/commit/7f622a42d9c132eb1eaed9ea118328c2ac04b52d
Submitter: "Robert Lyon <robertl@xxxxxxxxxxxxxxx>"
Branch:    21.10_DEV

commit 7f622a42d9c132eb1eaed9ea118328c2ac04b52d
Author: Dianne Tennent <dianne.tennent@xxxxxxxxxxxxxxx>
Date:   Fri Jul 22 11:40:07 2022 +1200

Bug 1982520: Error with old block configdata

Ensure $configdata['instructions'] exists before trying to rewrite it

Change-Id: I21f9643a778ccd80f52910b27f711d287fce005b
(cherry picked from commit 1f32844b81c17adef8ee80c58b3603010099bef3)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1982520

Title:
  Error with old block configdata

Status in Mahara:
  Fix Committed
Status in Mahara 21.04 series:
  Fix Committed
Status in Mahara 21.10 series:
  Fix Committed
Status in Mahara 22.04 series:
  Fix Committed
Status in Mahara 22.10 series:
  Fix Committed

Bug description:
  This error surfaced when creating a new account on a client site based
  on a template:

  [WAR] 57 (blocktype/text/lib.php:437) Undefined index: instructions

  Call stack (most recent first):

      log_message("Undefined index: instructions", 8, true, true, "/htdocs/blocktype/text/...", 437) at /htdocs/lib/errors.php:515
      error(8, "Undefined index: instructions", "/htdocs/blocktype/text/...", 437, array(size 7)) at /htdocs/blocktype/text/lib.php:437
      PluginBlocktypeText::rewrite_blockinstance_extra_config(object(View), object(BlockInstance), array(size 3), array(size 0)) at /htdocs/lib/mahara.php:1914
      call_static_method("PluginBlocktypeText", "rewrite_blockinstance_extra_config", object(View), object(BlockInstance), array(size 3), array(size 0)) at /htdocs/blocktype/lib.php:2709
      BlockInstance->copy(object(View), object(View), array(size 0)) at /htdocs/lib/view.php:6298
      View->copy_contents(object(View), array(size 0)) at /htdocs/lib/view.php:497
      View::create_from_template(array(size 4), "8", 27590, false, false, array(size 0)) at /htdocs/auth/user.php:1681
      User->copy_views(array(size 8), false) at /htdocs/auth/user.php:1783
      User->copy_site_views_collections_to_new_user() at /htdocs/lib/user.php:2777
      create_user(object(stdClass), array(size 0), object(Institution), null) at /htdocs/auth/lib.php:2310
      login_submit(object(Pieform), array(size 5)) at /htdocs/lib/pieforms/pieform.php:577
      Pieform->__construct(array(size 10)) at /htdocs/lib/mahara.php:5733
      pieform_instance(array(size 10)) at /htdocs/auth/lib.php:600
      auth_setup() at /htdocs/init.php:424
      require("/htdocs/init.php") at /htdocs/index.php:16

  Happens when copying old blocks that don't have
  $configdata['instructions']

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1982520/+subscriptions