mahara-contributors team mailing list archive

[Mahara Bot <1971702@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/c/mahara/+/12980
Committed: https://git.mahara.org/mahara/mahara/commit/8014dcd63c7f74614663f853ec0a1ae98494c36d
Submitter: "Robert Lyon <robertl@xxxxxxxxxxxxxxx>"
Branch:    main

commit 8014dcd63c7f74614663f853ec0a1ae98494c36d
Author: Davo Smith <davo.smith@xxxxxxxxxxxxxxxxxxxx>
Date:   Wed Jul 6 11:21:46 2022 +1200

Bug 1971702: Unable to configure mnet

Change-Id: I2ec78a74a036b7500f83a16e0bef2a0fbe780aec

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1971702

Title:
  Unable to configure mnet

Status in Mahara:
  Fix Committed
Status in Mahara 22.04 series:
  Fix Committed
Status in Mahara 22.10 series:
  Fix Committed

Bug description:
  Relates to bug 1955101

  When trying to configure an XML-RPC SSO for an institution, the
  function Peer->bootstrap() is called.

  On line 264 of lib/peer.php, it calls $this->set('publickey',
  $publickey); where $publickey is an instance of class PublicKey,
  created on the previous line.

  On line 82 onwards of lib/peer.php, it sets $this->publickey to that
  instance of the PublicKey class, then on line 90, it attempts to set
  the private field $certificate of this PublicKey instance - this
  results in a fatal error and the settings cannot be saved.

  Adjusting the code from:

              else if ($field == 'publickey') {
                  if (!is_object($this->publickey)) {
                      $this->publickey = new stdClass();
                  }
                  $this->publickey->certificate = $value;
              }

  to:

              else if ($field == 'publickey') {
                  if (!is_object($this->publickey)) {
                      $this->publickey = new stdClass();
                      $this->publickey->certificate = $value;
                  }
              }

  Seems to solve the problem.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1971702/+subscriptions