← Back to team overview

mahara-contributors team mailing list archive

[Bug 1975428] A change has been merged

 

Reviewed:  https://reviews.mahara.org/c/mahara/+/13026
Committed: https://git.mahara.org/mahara/mahara/commit/46483b694e2c8eb11ba95bbb0e5fa6888755065e
Submitter: "Robert Lyon <robertl@xxxxxxxxxxxxxxx>"
Branch:    22.04_DEV

commit 46483b694e2c8eb11ba95bbb0e5fa6888755065e
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Mon May 23 09:04:23 2022 +1200

Bug 1975428: Need to check if affiliations are used before removing old
ones

Change-Id: I19313946e2137a796f0fc47e3b61e2ace0494e6f
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit 6de118d76467a39163e6c2772273163287deee43)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1975428

Title:
  SAML is removing people from institutions when it shouldn't

Status in Mahara:
  Fix Committed
Status in Mahara 22.04 series:
  Fix Committed
Status in Mahara 22.10 series:
  Fix Committed

Bug description:
  With the addition of affiliated institutions code in SAML - that is,
  pass in a list of institutions the person is associated with over and
  above the one the SAML instance is connected to, so we can add the
  user to multiple institutions at once. There was a bit of code to
  remove them from institutions that they are not associated with
  anymore on login.

  But the problem with that bit of code was it runs even if the
  affiliated institutions are not being used.

  We need to only do the removal of associated institutions if the SAML
  instance is set up to handle affiliations

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1975428/+subscriptions



References