← Back to team overview

mahara-contributors team mailing list archive

[Bug 1975753] A change has been merged

 

Reviewed:  https://reviews.mahara.org/c/mahara/+/13034
Committed: https://git.mahara.org/mahara/mahara/commit/392b08e42c43dc7f98020623c4c6464065d823ca
Submitter: "Doris Tam <doristam@xxxxxxxxxxxxxxx>"
Branch:    22.04_DEV

commit 392b08e42c43dc7f98020623c4c6464065d823ca
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Thu May 26 11:20:05 2022 +1200

Bug 1975753: Include mahara.js before plugins

In case they rely on a function in mahara.js

Change-Id: I5e30e01de5fd4e4de7a4f2d87f662e907ff7c651
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit e56698bc0548ebf97101b78c227dea6a04adc11c)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1975753

Title:
  Plans js error - Uncaught ReferenceError: findButtonDataUrls is not
  defined

Status in Mahara:
  Fix Committed
Status in Mahara 21.10 series:
  Fix Committed
Status in Mahara 22.04 series:
  Fix Committed
Status in Mahara 22.10 series:
  Fix Committed

Bug description:
  We include the javascript for Plans before the mahara.js file where
  the findButtonDataUrls() is defined.

  We need to include mahara.js before the plugins js

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1975753/+subscriptions



References