mahara-contributors team mailing list archive

[Mahara Bot <1985857@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/c/mahara/+/13124
Committed: https://git.mahara.org/mahara/mahara/commit/ea3160ee4ba20fd96404ed2d63c0ea527ee13cc1
Submitter: "Robert Lyon <robertl@xxxxxxxxxxxxxxx>"
Branch:    main

commit ea3160ee4ba20fd96404ed2d63c0ea527ee13cc1
Author: veronicavarsha <veronicavarsha@xxxxxxxxxxxxxxx>
Date:   Wed Aug 31 12:59:02 2022 +1200

Bug #1985857: Fix for issue with disappearing theme when portfolio is
shared and made copyable

We need to better define when one can see / pick from
'userscanchooseviewthemes' dropdown

Signed-off-by: veronicavarsha <veronicavarsha@xxxxxxxxxxxxxxx>
Change-Id: Idf38ff852efa878cabfc8849a8e7ae1f668ba1c2

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1985857

Title:
  If a portfolio is shared and made copyable then it's page theme
  disappears

Status in Mahara:
  Fix Committed
Status in Mahara 21.04 series:
  Confirmed
Status in Mahara 21.10 series:
  Confirmed
Status in Mahara 22.04 series:
  Confirmed
Status in Mahara 22.10 series:
  Fix Committed

Bug description:
  It is due to the change in
  https://reviews.mahara.org/c/mahara/+/4064/12/htdocs/lib/view.php#5990

  To replicate:
  1) Turn on allow page themes in Admin -> Settings under the Accounts section
  2) Create a page and in Advanced settings give is a theme, say modern

  View the page - it should have theme showing

  3) Share the page with someone else and set allow copying to be true
  4) Edit the settings for the page - the ability to choose a theme now gone (no field in form)

  The change was added in relation to site templates but effects other
  pages made copyable too

  What we need is to also check that the view is owned by a
  site/institution and/or the person is allowed to choose themes is
  on/off and who is viewing it

  Owner viewing own page should always be able to see the theme.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1985857/+subscriptions