mahara-contributors team mailing list archive

[Mahara Bot <1987354@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/c/mahara/+/13146
Committed: https://git.mahara.org/mahara/mahara/commit/a900ed563dfe08c6877b685dd64f5c16722e2417
Submitter: "Robert Lyon <robertl@xxxxxxxxxxxxxxx>"
Branch:    22.04_DEV

commit a900ed563dfe08c6877b685dd64f5c16722e2417
Author: veronicavarsha <veronicavarsha@xxxxxxxxxxxxxxx>
Date:   Wed Sep 7 14:45:44 2022 +1200

Bug #1987354: Adding checks to fix share permissions removal on editing
institution collection

Signed-off-by: veronicavarsha <veronicavarsha@xxxxxxxxxxxxxxx>
Change-Id: I0cccb9642115e5ca2bc64b03ef0816b4bca28697
(cherry picked from commit a279018ef3118de3bf403c1a3c7603eafca15d99)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1987354

Title:
  Sharing permissions for institution removed when editing institution
  collection details

Status in Mahara:
  Fix Committed
Status in Mahara 21.10 series:
  Fix Committed
Status in Mahara 22.04 series:
  Fix Committed
Status in Mahara 22.10 series:
  Fix Committed

Bug description:
  When you shared an institution collection with the institution and
  then edit the collection 'Settings' screen, the permissions are
  revoked and the portfolio is not shared with the institution any more.

  To replicate:

  1. Add an institution.
  2. Create a page and add it to a collection. Don't select auto-copy for the collection.
  3. Share the collection with the entire institution (and also registered account holders).
  4. Edit the collection title and save the change.

  Results:
  - Expected: Sharing permissions persist and are not changed.
  - Actual: The sharing permission for the institution is lost whereas the one for registered account holders is retained.

  I don't see any reason why the sharing permissions should be removed.
  they should stay.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1987354/+subscriptions