mahara-contributors team mailing list archive

[Mahara Bot <1980021@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/c/mahara/+/13160
Committed: https://git.mahara.org/mahara/mahara/commit/eecb6e99b50662278eeb8d9df05a87d7c5741d4e
Submitter: "Robert Lyon <robertl@xxxxxxxxxxxxxxx>"
Branch:    main

commit eecb6e99b50662278eeb8d9df05a87d7c5741d4e
Author: Gold <gold@xxxxxxxxxxxxxxx>
Date:   Mon Sep 12 14:22:33 2022 +1200

Bug 1980021: session_get_instance() does not exist

Digging into this I found that this was added in commit
e099440c5839516a61863809683ffcfbd92f9740 and at that point the function
wasn't present either. A full search of the git history shows only that
commit that includes the string so I'm thinking it is a safe bet that
this code has never been executed.

Removing the call and surrounding code.

Signed-off-by: Gold <gold@xxxxxxxxxxxxxxx>
Change-Id: I82c8a837e3d2f3359839830148c75321c7fead6d

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1980021

Title:
  session_get_instance() does not exist

Status in Mahara:
  Fix Committed

Bug description:
  While working #1976432 I found that session_get_instance() does not
  appear to be defined anywhere. A quick search suggests it may have
  come from a Moodle module.  In the current version of Moodle this has
  also been deprecated.

  https://github.com/netspotau/moodle-
  mod_assign/blob/master/lib/sessionlib.php

  Given no errors have been reported around this we could remove the
  if() block it appears in.

  The instance of this is here:

  https://git.mahara.org/mahara/mahara/-/blob/main/htdocs/webservice/lib.php#L1251

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1980021/+subscriptions