mahara-contributors team mailing list archive

[Mahara Bot <1987027@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/c/mahara/+/13152
Committed: https://git.mahara.org/mahara/mahara/commit/54c2cd609d1db145e5317f14447a1b75c97b2adb
Submitter: "Robert Lyon <robertl@xxxxxxxxxxxxxxx>"
Branch:    21.04_DEV

commit 54c2cd609d1db145e5317f14447a1b75c97b2adb
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Fri Aug 19 16:37:37 2022 +1200

Bug 1987027: Correctly save MNet parent auth on account creation

Change-Id: I666a76e14ba84a4a1c036aff448c480039203ddb
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit 38c8c5d04f06dafd1e0466a81ffc51aef66d5e64)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1987027

Title:
  MNet failing to set parent auth correctly when creating account via
  MNet

Status in Mahara:
  Fix Committed
Status in Mahara 21.04 series:
  Fix Committed
Status in Mahara 21.10 series:
  Fix Committed
Status in Mahara 22.04 series:
  Fix Committed
Status in Mahara 22.10 series:
  Fix Committed

Bug description:
  MNet has the ability to set a parent authentication instance so that
  when an account is created that is the value saved as 'authinstance'
  instead.

  However, there is a bug in the code where 'internal' gets saved every
  time.

  This is very old bug which has caused much head-scratching over the
  years.

  To test
  1 Have a Mahara site that one can MNet into from something like a Moodle site
  2 Have the MNet instance set up to have a parent auth that is not internal, say SAML
  3 Have a person that doesn't have a mahara account log in via MNet jump link

  Expected 
  new account created with their 'authinstance' being SAML option

  Actual
  new account created with their 'authinstance' being internal option

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1987027/+subscriptions