← Back to team overview

mahara-contributors team mailing list archive

[Bug 1976429] A change has been merged

 

Reviewed:  https://reviews.mahara.org/c/mahara/+/12964
Committed: https://git.mahara.org/mahara/mahara/commit/2da315a33830394180dc7f87ae440d3f1577a76f
Submitter: "Doris Tam <doristam@xxxxxxxxxxxxxxx>"
Branch:    main

commit 2da315a33830394180dc7f87ae440d3f1577a76f
Author: Gold <gold@xxxxxxxxxxxxxxx>
Date:   Wed Jun 29 14:08:55 2022 +1200

Bug 1976429: PHP 8 Compatibility: testing

This patchset covers the following directories:

* htdocs/testing
* test/behat

Added a sleep(1) to the following behat definition steps to allow
the scroll to complete.

* i_scroll_into_view
* i_scroll_into_view_base
* i_scroll_into_view_center
* i_scroll_into_id_like

Signed-off-by: Gold <gold@xxxxxxxxxxxxxxx>
Change-Id: I4d866ef9d6c97af27ccac9a9a306534b1cf92200

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1976429

Title:
  PHP 8 Compatibility: testing

Status in Mahara:
  Fix Committed

Bug description:
  This is to track patchsets that will bring the codebase up to be
  compliant with PHP 8.1.

  The initial run through will be on a top level directory basis. i.e.
  the directories below htdocs. It will focus on the results from the
  PHPStan and Phan static analysis tools.

  This bug tracks files in the testing directory.

  Testing will require identifying, from the patchset, where the code is
  used and then verifying that that area of the site still works in both
  PHP 7.4 and PHP 8.1.

  https://phpstan.org/
  https://github.com/phan/phan

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1976429/+subscriptions



References