mahara-contributors team mailing list archive

[Mahara Bot <1976409@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/c/mahara/+/12821
Committed: https://git.mahara.org/mahara/mahara/commit/d3dc82d5ff346f340252bce03c5b3985fdab6cd5
Submitter: "Robert Lyon <robertl@xxxxxxxxxxxxxxx>"
Branch:    main

commit d3dc82d5ff346f340252bce03c5b3985fdab6cd5
Author: Gold <gold@xxxxxxxxxxxxxxx>
Date:   Thu May 26 08:19:25 2022 +1200

Bug 1976409: PHP 8 Compatibility: lib/dwoo

Stripping Dwoo out into its own patchset.

Also removed Dwoo from the exclution list on phpstan. We need that so we
can parse it.

* call_user_func_array() is stricter than it used to be. If issues
occur check the $params. You may need to send array_values($params)

Starting to add small items from outside of lib/dwoo so we can get behat
to pass.

Change-Id: Id8bb19f42dee309766c32a7aed143131f9e241e3

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1976409

Title:
  PHP 8 Compatibility: Dwoo

Status in Mahara:
  Fix Committed

Bug description:
  This is to track patchsets that will bring the codebase up to be
  compliant with PHP 8.1.

  The initial run through will be on a top level directory basis. i.e.
  the directories below htdocs. It will focus on the results from the
  PHPStan and Phan static analysis tools.

  This bug tracks files in Dwoo.

  Testing will require identifying, from the patchset, where the code is
  used and then verifying that that area of the site still works in both
  PHP 7.4 and PHP 8.1.

  https://phpstan.org/
  https://github.com/phan/phan

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1976409/+subscriptions