mahara-contributors team mailing list archive

[Mahara Bot <1990981@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/c/mahara/+/13503
Committed: https://git.mahara.org/mahara/mahara/commit/6ccbfc1f0d55da182b2888f59c46bed045725980
Submitter: "Robert Lyon <robertl@xxxxxxxxxxxxxxx>"
Branch:    22.10_DEV

commit 6ccbfc1f0d55da182b2888f59c46bed045725980
Author: Stefan Bäcker <unknown>
Date:   Thu Nov 10 14:25:19 2022 +1300

Bug 1990981: Appending parameters correctly again to copy portfolios
into group

There was an error in commit c830632494ef914ae26a07142e7ee35cb8074483
on line 6453 (now line 6516)

Before:

!empty($params)

After

!$params

Should be

$params

Change-Id: I61779f9b3bd65ae802362e7c839b8e6a5c55b0bc
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit b8762df369d815ee6eefac14e72d149f5ad1e70b)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1990981

Title:
  Unable to copy pages or collections into group

Status in Mahara:
  Fix Committed
Status in Mahara 22.04 series:
  Fix Committed
Status in Mahara 22.10 series:
  Fix Committed
Status in Mahara 23.04 series:
  Fix Committed

Bug description:
  When trying to copy a page or collection into a group, the group
  information gets lost when moving away from the first page of
  candidates. Collections will be copied, but into the personal area,
  not into the desired group.

  Debugging shows line 6504 in lib/view.php to be the culprit. Adding
  params only when there are none makes no sense. Removing the negation
  seems to solve the problem. Please find patch included.

  First part of patch solves a type mismatch error related to copying pages with certain artefacts.
  Second part solves this actual bug.

  Mahara version 22.04.2
  Ubuntu 20.04
  MariaDB 10.3

  Reproducible on current demo.mahara.org

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1990981/+subscriptions