mahara-contributors team mailing list archive

[Mahara Bot <1997280@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/c/mahara/+/13562
Committed: https://git.mahara.org/mahara/mahara/commit/0cfa520b6e14cee8a6aef40cdcf1c0e511775545
Submitter: "Robert Lyon <robertl@xxxxxxxxxxxxxxx>"
Branch:    22.10_DEV

commit 0cfa520b6e14cee8a6aef40cdcf1c0e511775545
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Tue Nov 22 11:26:10 2022 +1300

Bug 1997280: Refining the webservice check

To match the exact row we care about

Change-Id: I1aad492a689f7393bb4ec8e194060f18dc20b2a3
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit 220b3ae6a6edaf653b8797d078875bc41f7345ad)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1997280

Title:
  LTI/LTI_Advantage and webservice check

Status in Mahara:
  Fix Committed
Status in Mahara 22.10 series:
  Fix Committed
Status in Mahara 23.04 series:
  Fix Committed

Bug description:
  Now that we pair up webservice auth instances to the thing that
  required them it means we can have more than one auth instance where
  the institution and authmethod are the same.

  But in LTI / LTI_Advantage we do a get_field() check that expects only
  one record to be returned.

  We need to adjust this check to make sure at least one record exists.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1997280/+subscriptions