mahara-contributors team mailing list archive

[Mahara Bot <1997918@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/c/mahara/+/13566
Committed: https://git.mahara.org/mahara/mahara/commit/ba18b0d3661b20f6469e7e97ae6ffb9af58aed91
Submitter: "Robert Lyon <robertl@xxxxxxxxxxxxxxx>"
Branch:    22.10_DEV

commit ba18b0d3661b20f6469e7e97ae6ffb9af58aed91
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Fri Nov 25 12:13:36 2022 +1300

Bug 1997918: Fix issue with nested <A> links

Nested links are illegal - The a element can be wrapped around entire
paragraphs, lists, tables, and so forth, even entire sections, so long
as there is no interactive content within (e.g., buttons or other links).

We now have the 'From' link be part of the list within the
collapsible body

Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Change-Id: Iecdefb95f9471eaa6dd68a6073e91c85b94f39dc
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
(cherry picked from commit c7035977109743834f0da6503c523c3175054d1d)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1997918

Title:
  Message "send message" page has broken layout due to nested <A> tags

Status in Mahara:
  Fix Committed
Status in Mahara 22.10 series:
  Fix Committed
Status in Mahara 23.04 series:
  Fix Committed

Bug description:
  Currently under certain conditions the previous message display looks
  broken in the collapsible area part.

  This is due to a <a> tag being nested within another <a> tag.

  Coding standards say "Nested links are illegal - The a element can be wrapped around entire
  paragraphs, lists, tables, and so forth, even entire sections, so long
  as there is no interactive content within (e.g., buttons or other links)."

  We need to fix this up so that it follows html guidelines and also
  keeps the info we want

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1997918/+subscriptions