← Back to team overview

mahara-contributors team mailing list archive

[Bug 1997490] A change has been merged

 

Reviewed:  https://reviews.mahara.org/c/mahara/+/13491
Committed: https://git.mahara.org/mahara/mahara/commit/68036e2e0f0fde143459d617091c4a06d22bc938
Submitter: "Robert Lyon <robertl@xxxxxxxxxxxxxxx>"
Branch:    main

commit 68036e2e0f0fde143459d617091c4a06d22bc938
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Wed Nov 23 10:24:40 2022 +1300

Bug 1997490: Allow site admins to share site/institution pages to public

If they are added to an institution.
They still have to respect the site/institution share to public rules
though.

For example:
Site admin is in Institution A that doesn't allow public pages

The should still be able to:
- share site pages to public
- share Instituion B pages to public

Change-Id: Ifa299c0fd9487caf49e49a86e771a307d6309d8b
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/1997490

Title:
  Site admin can't share a page to public if they are in an institution
  that doesn't allow public sharing

Status in Mahara:
  Fix Committed

Bug description:
  The issue is the view access form when deciding to slow the 'public'
  option checks to see if the website has 'allowpublicviews' on (site
  setting) and that the person who is editing access is in an
  institution that allows public views.

  Normally the site admin is in 'No institution' and so that is seen as
  allowed by default when 'allowpublicviews' is true.

  But if the site admin is in an institution then that institutions
  settings come into play. And if that institution doesn't allow it then
  the site admin can't share a page to public even if that page is a not
  in the institution, like a site page.

  So we need an extra rule for site admins who exist in an institution
  that doesn't allow public access. This rule should allow them to still
  be able to make site/institution pages public.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1997490/+subscriptions



References