mahara-contributors team mailing list archive

[Kristina Hoeppner <2004852@xxxxxxxxxxxxxxxxxx>]

Thank you for the report, Marie-Eve. We'll review your suggestion and
put it through our code review system.

Note for testing: This would be for LTI 1.1, using the 'External tool'
option in Moodle.

** Also affects: mahara/22.10
   Importance: Undecided
       Status: New

** Also affects: mahara/23.04
   Importance: Undecided
       Status: New

** Changed in: mahara/23.04
    Milestone: None => 23.04.0

** Changed in: mahara/22.10
    Milestone: None => 22.10.1

** Changed in: mahara/23.04
   Importance: Undecided => High

** Changed in: mahara/22.10
   Importance: Undecided => High

** Changed in: mahara/23.04
       Status: New => Confirmed

** Changed in: mahara/22.10
       Status: New => Confirmed

** Also affects: mahara/22.04
   Importance: Undecided
       Status: New

** Also affects: mahara/21.10
   Importance: Undecided
       Status: New

** Changed in: mahara/22.04
   Importance: Undecided => High

** Changed in: mahara/21.10
   Importance: Undecided => High

** Changed in: mahara/22.04
       Status: New => Confirmed

** Changed in: mahara/21.10
       Status: New => Confirmed

** Changed in: mahara/22.04
    Milestone: None => 22.04.4

** Changed in: mahara/21.10
    Milestone: None => 21.10.6

** Summary changed:

- LTI grading not working for some locales
+ LTI 1.1 grading not working for some locales

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/2004852

Title:
  LTI 1.1 grading not working for some locales

Status in Mahara:
  Confirmed
Status in Mahara 21.10 series:
  Confirmed
Status in Mahara 22.04 series:
  Confirmed
Status in Mahara 22.10 series:
  Confirmed
Status in Mahara 23.04 series:
  Confirmed

Bug description:
  With a LTI to a Moodle instance, when the teachers grades a
  submission, the grade is not sent to Moodle in some cases. I think it
  has to do with my server's locale set to french. The grade of 94%, for
  example, si translated to 0,94 instead of 0.94.

  I printed some debug and was able to see the error "Score must be
  numeric". I also printed the xml from the $body variable (see
  attachment).

  I made a few changes in function publish_lti_outcome of
  htdocs/module/lti/lib.php around line 1001 and it now works correctly.

  $grade = $this->grade / 100;
  $grade = str_replace(',', '.', $grade);
  $smarty->assign('score', $grade);

  This was tested with Mahara 22.10 and Moodle 3.11.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/2004852/+subscriptions