← Back to team overview

mahara-contributors team mailing list archive

[Bug 2003378] A change has been merged

 

Reviewed:  https://reviews.mahara.org/c/mahara/+/13625
Committed: https://git.mahara.org/mahara/mahara/commit/e8c1544a825e9d214ba58eaa40c3286cc8e1375e
Submitter: "Doris Tam <doristam@xxxxxxxxxxxxxxx>"
Branch:    main

commit e8c1544a825e9d214ba58eaa40c3286cc8e1375e
Author: Gold <gold@xxxxxxxxxxxxxxx>
Date:   Fri Jan 20 11:47:59 2023 +1300

Bug 2003378: PHP8 Compatibility: final warnings

* Since PHP 7.0, functions inspecting arguments, like func_get_args() and
debug_backtrace() no longer report the original value as passed to a
parameter, but will instead provide the current value.
* The locations phpcs found don't appear to be impacted though. Supressing
the warning.
* PHP has reserved all method names with a double underscore prefix.

Signed-off-by: Gold <gold@xxxxxxxxxxxxxxx>
Change-Id: I91bfc27e232818a105b9342e4ac4056bbb706a72

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/2003378

Title:
  PHP 8 Compatibility: phpcs

Status in Mahara:
  Fix Committed

Bug description:
  We're getting close to finishing this.  We are currently working
  through the output of PHP CodeSniffer. This bug is a catchall bug to
  cover this work.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/2003378/+subscriptions



References