mahara-contributors team mailing list archive

[Kristina Hoeppner <2006514@xxxxxxxxxxxxxxxxxx>]

** Changed in: mahara
       Status: New => Confirmed

** Changed in: mahara
   Importance: Undecided => High

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/2006514

Title:
  Inconsistent Sign-off blocks after upgrade

Status in Mahara:
  Confirmed

Bug description:
  When rebasing a patchset on main I noticed a Page had lost the Sign-
  off block. This Page **was not** in a signed off state. The other Page
  in the Collection also had the block, **was** in a Signed off state,
  and did still have the new form of the block.

  I think the upgrade step here needs to be updated. It's working for
  block instances that are signed off, but not for those that aren't.

  https://git.mahara.org/mahara/mahara/-/blob/main/htdocs/lib/db/upgrade.php#L975

  Testing:

  Checkout 22.10_RELEASE and install the site
  Create an account
  As that account, create 2 Pages and add them to a Collection
  Add Progress Completion to the Collection
  Sign-off blocks to both pages
  Mark the first Page as Signed off.

  Back up the DB for handy restoring during development.

  Checkout main
  Run the upgrade
  Look at the Collection and pages.

  Expected result:
  * A Collection with a Progress Completion page
  * The Progress Completion page to shows the first Page with the Sign-off state with a signed off indicator
  * The Progress Completion page to shows the second Page with the Sign-off state with a not signed off indicator
  * The first Page to have the new form of the Sign-off block in a signed off state
  * The second Page to have the new form of the Sign-off block in a not signed off state

  The current result:

  * A Collection with a Progress Completion page
  * The Progress Completion page to shows the first Page with the Sign-off state with a signed off indicator
  * The Progress Completion page to shows the second Page **with no** Sign-off state indicator
  * The first Page has the new form of the Sign-off block in a signed off state
  * The second Page **does not have have** the new form of the Sign-off block in a not signed off state

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/2006514/+subscriptions