mahara-contributors team mailing list archive

[Robert Lyon <2006637@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

When we add a new view type we update the blocktype_installed_viewtype
table to know what blocks can be used on this new view type.

But if we have an upgrade path where we add two new view types in one
upgrade session then the information is not correct from
Blocktype::get_viewtypes() because it is set to be static.

We need it to ignore this static-ness on upgrade.

To test:

Install a 20.04_STABLE site
Upgrade to main
Run the following command in database:
select * from blocktype_installed_viewtype where viewtype = 'activity' order by blocktype;

Should see:
29 (or 30) rows including 'placeholder' and 'image' blocktypes

Actually see:

21 (or 22) rows and 'placeholder' and 'image' blocktypes are missing

** Affects: mahara
     Importance: High
         Status: In Progress

** Affects: mahara/21.10
     Importance: High
         Status: New

** Affects: mahara/22.04
     Importance: High
         Status: New

** Affects: mahara/22.10
     Importance: High
         Status: New

** Affects: mahara/23.04
     Importance: High
         Status: In Progress

** Changed in: mahara
    Milestone: None => 23.04.0

** Changed in: mahara
   Importance: Undecided => High

** Changed in: mahara
       Status: New => In Progress

** Also affects: mahara/23.04
   Importance: High
       Status: In Progress

** Also affects: mahara/22.04
   Importance: Undecided
       Status: New

** Also affects: mahara/22.10
   Importance: Undecided
       Status: New

** Also affects: mahara/21.10
   Importance: Undecided
       Status: New

** Changed in: mahara/22.10
   Importance: Undecided => High

** Changed in: mahara/22.04
   Importance: Undecided => High

** Changed in: mahara/21.10
   Importance: Undecided => High

** Changed in: mahara/22.10
    Milestone: None => 22.10.1

** Changed in: mahara/22.04
    Milestone: None => 22.04.4

** Changed in: mahara/21.10
    Milestone: None => 21.10.6

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/2006637

Title:
  Issue with upgrade and setting the blocktype_installed_viewtypes
  values correctly

Status in Mahara:
  In Progress
Status in Mahara 21.10 series:
  New
Status in Mahara 22.04 series:
  New
Status in Mahara 22.10 series:
  New
Status in Mahara 23.04 series:
  In Progress

Bug description:
  When we add a new view type we update the blocktype_installed_viewtype
  table to know what blocks can be used on this new view type.

  But if we have an upgrade path where we add two new view types in one
  upgrade session then the information is not correct from
  Blocktype::get_viewtypes() because it is set to be static.

  We need it to ignore this static-ness on upgrade.

  To test:

  Install a 20.04_STABLE site
  Upgrade to main
  Run the following command in database:
  select * from blocktype_installed_viewtype where viewtype = 'activity' order by blocktype;

  Should see:
  29 (or 30) rows including 'placeholder' and 'image' blocktypes

  Actually see:

  21 (or 22) rows and 'placeholder' and 'image' blocktypes are missing

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/2006637/+subscriptions