mahara-contributors team mailing list archive

[Mahara Bot <2004137@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/c/mahara/+/13809
Committed: https://git.mahara.org/mahara/mahara/commit/396c0bc0b773e853188dfc8dbcad1e9c8e3fc608
Submitter: "Robert Lyon <robertl@xxxxxxxxxxxxxxx>"
Branch:    22.10_DEV

commit 396c0bc0b773e853188dfc8dbcad1e9c8e3fc608
Author: Gold <gold@xxxxxxxxxxxxxxx>
Date:   Tue Jan 31 12:01:20 2023 +1300

Bug 2004137: Type declaration error in php 7.4

Turns out the type declaration of 'mixed' is not supported in PHP 7.4.
Removing for now.

Signed-off-by: Gold <gold@xxxxxxxxxxxxxxx>
Change-Id: I374f2fea81cebdacfaf0e1fa1b04021981b6d878
(cherry picked from commit 90b9943a60d9a1f3f81d417ec86ba84f9b11df02)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/2004137

Title:
  PHP 8 compatibility causing error with PHP 7.4 for XML-RPC

Status in Mahara:
  Fix Committed
Status in Mahara 22.10 series:
  Fix Committed
Status in Mahara 23.04 series:
  Fix Committed

Bug description:
  Mahara: 22.10.0
  DB: Postgres 14.3
  OS: Linux 20.04
  Browser: n/a

  The use of "mixed" type is supported in PHP 8.0+.

  It was introduced in this file:

  https://reviews.mahara.org/c/mahara/+/12921/28/htdocs/lib/applicationset.php

  with 2 functions:

  1. current() : mixed
  2. key() : mixed

  With PHP 7.4, when configuring institutions with Moodle integration
  (XML-RPC for example), the following error is received:

  "PHP message: [WAR] 40 (lib/errors.php:529) [TypeError]: Return value
  of ApplicationSet::current() must be an instance of mixed, instance of
  Application returned at /var/www/site/lib/applicationset.php:45

  A type should not be set for these functions until it's fully
  implemented for PHP 8.0+.

  I only found those 2 instances in Mahara 22.10

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/2004137/+subscriptions