← Back to team overview

mahara-contributors team mailing list archive

[Bug 2003990] A change has been merged

 

Reviewed:  https://reviews.mahara.org/c/mahara/+/13830
Committed: https://git.mahara.org/mahara/mahara/commit/096381df4c4c96cb586547e80acc601044619f29
Submitter: "Robert Lyon <robertl@xxxxxxxxxxxxxxx>"
Branch:    main

commit 096381df4c4c96cb586547e80acc601044619f29
Author: Gold <gold@xxxxxxxxxxxxxxx>
Date:   Mon Feb 27 10:41:22 2023 +1300

Bug 2003990: GrumPHP v2

Adds the current change id commit hook to the commit message that
GrumPHP over writes.  The presence of a change id on this commit message
is the actual test.

Signed-off-by: Gold <gold@xxxxxxxxxxxxxxx>
Change-Id: I4e5fbc11914a6d5886a197b6f14295688eb73e9b

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/2003990

Title:
  GrumPHP Mahara for linting on commits

Status in Mahara:
  New

Bug description:
  Currently pulls in our phpstan.neon file and runs phpstan on

  `git commit` related commands.

  Refer to https://github.com/phpro/grumphp

  Quick start:

  - composer require --dev phpro/grumphp
  - composer require --dev phpstan/phpstan

  In case SimpleSAMLPHP throws phpstan errors: run `make ssphp`

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/2003990/+subscriptions



References