mahara-contributors team mailing list archive

[Mahara Bot <2012419@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/c/mahara/+/13868
Committed: https://git.mahara.org/mahara/mahara/commit/94c6d0cbd526a505f6e9c631060cbc87eb973447
Submitter: "Robert Lyon <robertl@xxxxxxxxxxxxxxx>"
Branch:    main

commit 94c6d0cbd526a505f6e9c631060cbc87eb973447
Author: Laurent David <laurent@xxxxxxxxxxxxxxxx>
Date:   Tue Mar 21 18:50:14 2023 +0100

Bug 2012419: Error releasing submissions

Fix an issue with the $group parameter when calling group_external_group
with an integer identifier

Change-Id: I5acd1c1bcfb94f03947903acf88b2b97e40380f5

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: mahara-contributors
https://bugs.launchpad.net/bugs/2012419

Title:
  Error releasing submissions

Status in Mahara:
  Confirmed
Status in Mahara 22.10 series:
  In Progress
Status in Mahara 23.04 series:
  Confirmed

Bug description:
  To reproduce the issue, setup a new Mahara install (22.10.0 STABLE, Mysql).
  * Create 2 users Student and Teacher
  * Create an institution
  * Add the two users in the institution
  * Add a new group (Group 1) - With the 3 roles (Tutor, Member, Admin)
  * Add Student as Member of Group 1 and Teacher as Tutor in Group 1
  * As Student create a page and submit it for review in Group 1
  * As Teacher release the Page

  From this point an error will be displayed and the page will never be
  released and will be marked as "Pending release after archiving."

  The Error displayed is:

  Failed to get a recordset: mysqli error: [1064: You have an error in
  your SQL syntax; check the manual that corresponds to your MySQL
  server version for the right syntax to use near '?  LIMIT 1' at line
  1] in EXECUTE("SELECT * FROM "lti_assessment"  WHERE "group" = ?
  LIMIT 1")Command was: SELECT * FROM "lti_assessment"  WHERE "group" =
  ?

  ...

  When examining the issue with a debugger it seems that
  group_external_group($group) is called with an integer instead of a
  string, so it means that record_exists('lti_assessment', 'group',
  $group->id) is called with the wrong value (as $group->id does not
  exist).

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/2012419/+subscriptions